Setup Lists - Make allowedCurrencies property private

[ihor-sviziev]

Description

In #13770 was introduced new property with protected visibility, should be private.
This commit wasn't included into any release, so we still can fix this issue.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[r-martins]

@ihor-sviziev sorry for not seeing your previous comment on #13770.
I'm just wondering why $allowedLocales should be kept protected while $allowedCurrencies, private.
Thanks mate.

Update: Both variables has protected visibility, and has public methods to get its information. I also checked that there's no other usage outside the class for both properties. Can you confirm that? Perhaps both might be private...

[ihor-sviziev]

Hi @r-martins,
Unfortunately such change will be not backward compatible as it was already included as protected in one of releases.

[r-martins]

That's true. Thanks for replying. Sent from my Android.

…

On Wed., 7 Mar. 2018, 16:38 Ihor Sviziev, ***@***.***> wrote: Hi @r-martins <https://github.com/r-martins>, Unfortunately such change will be not backward compatible as it was already included as protected in one of releases. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13966 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AALqrQC6vOteFAIZ6zLtjDhgPg6rPGTIks5tb3JrgaJpZM4SeVV4> .