Pass Expected Data Type in backgroundColor Call (2.3) #13917
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
\Magento\Framework\Image::backgroundColoris expectingnull|arrayas valid parameter types. However, in\Magento\Swatches\Helper\Media::setupImagePropertiesthe string value '#FFF' is passed into this function call. The goal of this fix is to pass along the correct and expected type, which in this case is going to be an array of RGB values to produce the same end result.This can also be seen on
2.1-develop(addressed in #13916) and2.2-develop(addressed in #13914).Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist
Forwardport for #13914