Skip to content

[Port 2.3-develop] Load CMS Page using repository in save action #13815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2018
Merged

[Port 2.3-develop] Load CMS Page using repository in save action #13815

merged 1 commit into from
Mar 6, 2018

Conversation

@Jeroenll
Copy link
Member

@Jeroenll Jeroenll commented Feb 23, 2018 •
edited by okorshenko
Loading

Port of #13814

Description

Update Save action of CMS Page to load via repository. Also added testSaveActionNoId() to be consistent with CMS Bock tests

Fixed Issues (if relevant)

  1. None.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Load CMS Page using repository in save action
24fa8d6 
Also added testSaveActionNoId to be consistent with CMS Bock tests
@dmanners dmanners self-assigned this Feb 23, 2018
@magento-engcom-team magento-engcom-team added this to the March 2018 milestone Mar 2, 2018
@magento-engcom-team magento-engcom-team merged commit 24fa8d6 into magento:2.3-develop Mar 6, 2018
magento-engcom-team pushed a commit that referenced this pull request Mar 6, 2018
ENGCOM-675: [Port 2.3-develop] Load CMS Page using repository in save…
5f6781f 
… action #13815
@Jeroenll Jeroenll deleted the patch-17 branch March 20, 2018 10:45
@paales paales added Partner: Reach Digital Pull Request is created by partner Reach Digital and removed Partner: Reach Digital Pull Request is created by partner Reach Digital labels May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dmanners dmanners

@okorshenko okorshenko

Labels

Partner: Reach Digital Pull Request is created by partner Reach Digital Progress: accept Release Line: 2.3

Projects

None yet

Milestone

March 2018

Development

Successfully merging this pull request may close these issues.

5 participants

@Jeroenll @paales @dmanners @okorshenko @magento-engcom-team