Skip to content

Remove forced setting of cache_lifetime to false in constructor and set default cache_lifetime to 3600 #13762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2018
Merged

Remove forced setting of cache_lifetime to false in constructor and set default cache_lifetime to 3600 #13762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion app/code/Magento/Theme/Block/Html/Footer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ protected function _construct()
{
$this->addData(
[
'cache_lifetime' => false,
'cache_tags' => [\Magento\Store\Model\Store::CACHE_TAG, \Magento\Cms\Model\Block::CACHE_TAG],
]
);
Expand Down Expand Up @@ -123,4 +122,14 @@ public function getIdentities()
{
return [\Magento\Store\Model\Store::CACHE_TAG, \Magento\Cms\Model\Block::CACHE_TAG];
}

/**
* Get block cache life time
*
* @return int
*/
protected function getCacheLifetime()
Copy link
Contributor

@ihor-sviziev ihor-sviziev Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be public?

Copy link
Author

@zolat zolat Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @ihor-sviziev it is protected in \Magento\Framework\View\Element\AbstractBlock::getCacheLifetime

Copy link
Contributor

@ihor-sviziev ihor-sviziev Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok. So I approved your changes

{
return parent::getCacheLifetime() ?: 3600;
}
}