Skip to content

Conversation

@Jeroenll
Copy link
Member

@Jeroenll Jeroenll commented Feb 14, 2018

Port of #13653, #13654

Description

Using a config setting Yes/No will return string '0' when No is saved. Method will therefore fetch default config value because '0' equals false. Removed the ScopeConfigInterface::SCOPE_TYPE_DEFAULT because it's the default value.

Fixed Issues (if relevant)

  1. None I could find.

Manual testing scenarios

  1. Add config value to Store module in both default and store view scope.
  2. Set config on store scope to No.
  3. Value '0' is returned and value from default scope is fetched.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Using a config setting Yes/No will return string '0' when No is saved. Method will therefore fetch default config value because '0' equals false.
@rogyar rogyar self-assigned this Feb 14, 2018
@magento-engcom-team magento-engcom-team added this to the February 2018 milestone Feb 28, 2018
@okorshenko okorshenko modified the milestones: February 2018, March 2018 Mar 1, 2018
@magento-engcom-team magento-engcom-team merged commit 4700853 into magento:2.3-develop Mar 17, 2018
magento-engcom-team pushed a commit that referenced this pull request Mar 17, 2018
@Jeroenll Jeroenll deleted the patch-10 branch March 20, 2018 10:45
@paales paales added Partner: Reach Digital Pull Request is created by partner Reach Digital and removed Partner: Reach Digital Pull Request is created by partner Reach Digital labels May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner: Reach Digital Pull Request is created by partner Reach Digital Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants