Skip to content

Conversation

@barryvdh
Copy link
Contributor

@barryvdh barryvdh commented Feb 9, 2018

Description

When adding a new IP-address, you have to copy the existing ones. This adds a --add flag to just append the addresses, instead of replacing

Manual testing scenarios

  1. Set the IP address
  2. Add new ones with --add
  3. See the existing one still on the list

@barryvdh
Copy link
Contributor Author

I've added a basic test for this.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 12, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barryvdh in general your changes looks good, but static tests failing due to Cyclomatic Complexity of 10 in tests. Could you adjust your test to have less complexity or at least suppress the warning?

@barryvdh
Copy link
Contributor Author

@ihor-sviziev I tried to follow the existing test, but should I just create my own seperate test for this, instead of using the provider?

@barryvdh barryvdh force-pushed the patch-2 branch 4 times, most recently from 61aab30 to 5747bb3 Compare February 14, 2018 09:28
@barryvdh
Copy link
Contributor Author

@ihor-sviziev I've updated the tests. All checks are passing now.

@magento-engcom-team magento-engcom-team added this to the February 2018 milestone Feb 16, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
MAGETWO-87975 has been created to process this Pull Request

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the comma sign between IP-addresses on the line? #L152. I believe that this will help.

The test fails with:

Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Set exempt IP-addresses: 127.0.0.1, 127.0.0.2\n
+'Set exempt IP-addresses: 127.0.0.1 127.0.0.2\n

Please, fix the test and push again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that was changed since I made this PR. I've updated it now.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
MAGETWO-87975 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 56f4720 into magento:2.2-develop Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants