Skip to content

magento/magento2#11252: fix adminhtml file attribute edit form #13563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2018

Conversation

Mkennethsmith
Copy link

@Mkennethsmith Mkennethsmith commented Feb 8, 2018

Applying fix for issue 11252 to Magento2 version 2.2.2
Backport of #11267

Description

This fixes issue #11252 file not allowing uploads for custom customer attributes in the Admin environment. FileUploaderTest passes with implemented change.

Fixed Issues (if relevant)

  1. Custom attribute - File not allowing uploads #11252: Custom attribute - File not allowing uploads

Manual testing scenarios

  1. Create a Customer custom attribute of type file
  2. Attempt to upload a file in the admin panel.
  3. Run Unit test app/code/Magento/Customer/Test/Unit/Model/FileUploaderTest.php

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 8, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Mkennethsmith
❌ mustdobetter

@orlangur
Copy link
Contributor

orlangur commented Feb 8, 2018

Nice catch @Mkennethsmith! This is a backport of https://github.com/magento/magento2/pull/11267/files.

@orlangur orlangur self-assigned this Feb 8, 2018
@orlangur orlangur added this to the February 2018 milestone Feb 8, 2018
@magento-engcom-team
Copy link
Contributor

@Mkennethsmith thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants