Fix json encoded attribute backend type to not encode attribute value multiple times #13551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihor-sviziev
approved these changes
Feb 8, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 12, 2018
…t encode attribute value multiple times #13551
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 12, 2018
…t encode attribute value multiple times #13551
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 12, 2018
…t encode attribute value multiple times #13551
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 12, 2018
…attribute value multiple times #13551
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the last fix (#11947) the json encoded attribute value loaded back correctly, but if you save a product muliple times then the attribute value will also be encoded muliple times which will cause issue during the next load.
This PR fixes the
beforeSavemethod to only encode the attribute value when it is not encoded already.