Skip to content

Fix default discount tax calculation in double #13449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2018
Merged

Fix default discount tax calculation in double #13449

merged 1 commit into from
Feb 2, 2018

Conversation

@VincentMarmiesse
Copy link
Contributor

@VincentMarmiesse VincentMarmiesse commented Jan 31, 2018

Hello

Description

The node tax/calculation/discount_tax is in double in file Magento/Tax/etc/config.xml.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@VincentMarmiesse VincentMarmiesse mentioned this pull request Jan 31, 2018
Closed
4 tasks
@orlangur orlangur self-assigned this Feb 1, 2018
@orlangur orlangur added this to the February 2018 milestone Feb 1, 2018
@magento-engcom-team magento-engcom-team merged commit 7517cff into magento:2.2-develop Feb 2, 2018
magento-engcom-team pushed a commit that referenced this pull request Feb 2, 2018
MAGETWO-87352: Fix default discount tax calculation in double #13449
7787945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

Labels

Progress: accept Release Line: 2.2

Projects

None yet

Milestone

February 2018

Development

Successfully merging this pull request may close these issues.

3 participants

@VincentMarmiesse @orlangur @magento-engcom-team