[2.3-develop] Fix missing discount label in checkout

[ihor-sviziev]

Description

The discount label was not being shown in the shopping cart totals description
Continuing of #11883

Fixed Issues

1. Discount Rule does not show Default Rule Label #11497: Discount Rule does not show Default Rule Label
2. Cart Price Rule Label is not working #11428: Cart Price Rule Label is not working

Manual testing scenarios

1. Add a discount to quote
2. Go to the shopping cart and now see the discount label in the totals description

Related PRs

#13141
#13223

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[raymond62]

This seems to work out on most cases but it is not for nl_NL.

1) I have Magento 2.3 installed with a en_GB, de_DE and a nl_NL Store. Following the Order Process in en_GB and de_DE is working fine, no issues. The issue appears only in nl_NL on all browsers on pc and mobile devices. I have tried flush, clean, rm all static files, del cookies ...

2) Following the Order Process it shows following (in stead of the expected discount label text it shows "%s"):

3) When i change the language to de_DE or en_GB, the expected discount label text appears in nl_NL, what also is wrong. I expect it in the choosen language.
(in this case it should also be "VAT (19%)" and not "BTW (19%)". Those are set in the Tax Area. Seems to be another bug...):

4) Going back to nl_NL Store the "%s" is back again.

5) Case it helps, here additionally my Store Discount Labels that should appear on the side

Thank you for your assistance, i appreciate a lot

[ihor-sviziev]

Hi @raymond62,
Could you create separate issue for that?

[raymond62]

Thanks, opened new Issue #14494