Visual swatch images/colors were not visible in backoffice #13134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$newSwatch was initialized as a string but it was used as an array in both the function body and in the calling function.
This resulted in $newSwatch was always set to "b" (the first letter of "background"), and so the view did not get a correct style="background: url('xxxxx.xxx'); background-size: cover;"
This issue is only visible for PHP 7
Contributor
|
@Yonn-Trimoreau thank you for your contribution, but it looks like the same changes were already proposed in #13101 |
Author
|
Looks like you're right @ihor-sviziev ! Closing this pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual swatch images/colors were not visible in backoffice
Description
In
app/code/Magento/Swatches/Block/Adminhtml/Attribute/Edit/Options/Visual.phpat line 95: $newSwatch was initialized as a string but it was used as an array in both the function body and in the calling function.This resulted in $newSwatch was always set to "b" (the first letter of "background"), and so the view did not get a correct value for
style="background: url('xxxxx.xxx'); background-size: cover;"This issue is only visible for PHP 7
Fixed Issues (if relevant)
I fixed it before posting an issue. Maybe there is one but I could not find it.
Manual testing scenarios
Contribution checklist