Skip to content

Conversation

@nfourteen
Copy link
Contributor

Description

This pull request fixes street format spacing when multiple streets are present to be consistent across Shipping and Review & Payments checkout steps.

screen shot 2018-01-10 at 12 03 03 am

screen shot 2018-01-10 at 12 03 19 am

Manual testing scenarios

  1. On the frontend, create a customer account and enter a default address (leaving the street_2 form field blank).
  2. Add products to the cart and Proceed to Checkout
  3. Review the shipping address formats on both Shipping and Review & Payments checkout steps
  4. Update customer account address to include the street_2 form field
  5. Repeat steps 2 and 3 ensuring the spacing is consistent

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov ishakhsuvarov self-assigned this Jan 10, 2018
@ishakhsuvarov ishakhsuvarov added this to the January 2018 milestone Jan 10, 2018
@magento-team magento-team merged commit 98e8ea7 into magento:2.2-develop Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants