Skip to content

Fix Newsletter Subscribe Workflow #13044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2018
Merged

Fix Newsletter Subscribe Workflow #13044

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ab75ba
updated newsletter subscriber model
torhoehn Jan 5, 2018
93453a8
removed inline control structure
torhoehn Jan 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions app/code/Magento/Newsletter/Model/Subscriber.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,14 +604,20 @@ protected function _updateCustomerSubscription($customerId, $subscribe)

$this->save();
$sendSubscription = $sendInformationEmail;
if ($sendSubscription === null xor $sendSubscription) {
if ($sendSubscription === null xor $sendSubscription && $this->isStatusChanged()) {
try {
if ($isConfirmNeed) {
$this->sendConfirmationRequestEmail();
} elseif ($this->isStatusChanged() && $status == self::STATUS_UNSUBSCRIBED) {
$this->sendUnsubscriptionEmail();
} elseif ($this->isStatusChanged() && $status == self::STATUS_SUBSCRIBED) {
$this->sendConfirmationSuccessEmail();
switch ($status) {
case self::STATUS_UNSUBSCRIBED:
$this->sendUnsubscriptionEmail();
break;
case self::STATUS_SUBSCRIBED:
$this->sendConfirmationSuccessEmail();
break;
case self::STATUS_NOT_ACTIVE:
if ($isConfirmNeed) {
$this->sendConfirmationRequestEmail();
}
break;
}
} catch (MailException $e) {
// If we are not able to send a new account email, this should be ignored
Expand Down