Skip to content

Magento 2.2 Develop fix for #12221 Google Analytics Pageview Triggered twice #13034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 11, 2018
Merged

Magento 2.2 Develop fix for #12221 Google Analytics Pageview Triggered twice #13034

merged 2 commits into from
Jan 11, 2018

Conversation

@bhargavmehta
Copy link
Member

@bhargavmehta bhargavmehta commented Jan 7, 2018

Description

Fixing analytics issue for PageViews getting triggered twice.
#MM18IN

Fixed Issues (if relevant)

  1. Google analytics pageview being triggered twice #12221 : Google analytics pageview being triggered twice.

Manual testing scenarios

  1. Created a test Analytics account
  2. Triggered analytics data and checked via Google Tags tool (Tag Assistant by Google) in chrome.

@magento-engcom-team magento-engcom-team added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jan 7, 2018
@bhargavmehta bhargavmehta self-assigned this Jan 8, 2018
@bhargavmehta bhargavmehta requested a review from sidolov January 8, 2018 14:52
@bhargavmehta
Copy link
Member Author

bhargavmehta commented Jan 11, 2018

@dmanners and @magento-engcom-team Can anyone look into this?

@dmanners dmanners self-assigned this Jan 11, 2018
@dmanners dmanners added this to the January 2018 milestone Jan 11, 2018
@magento-team magento-team mentioned this pull request Jan 11, 2018
Closed
@magento-team magento-team merged commit e851948 into magento:2.2-develop Jan 11, 2018
magento-team pushed a commit that referenced this pull request Jan 11, 2018
@ishakhsuvarov
MAGETWO-86630: Magento 2.2 Develop fix for #12221 Google Analytics Pa…
c87d925 
…geview Triggered twice #13034
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 11, 2018
@bhargavmehta bhargavmehta deleted the 2.2-dev-fix branch January 12, 2018 08:46
@paddy194
Copy link

paddy194 commented Mar 14, 2018

I guess conversions dont get tracked after this fix.

@jschrab-lc
Copy link

jschrab-lc commented Apr 5, 2018 •
edited
Loading

@paddy194 I'm observing this too. To reiterate, it would appear this patch breaks the inclusion of ec.js and further ec.js related tracking.

This was mentioned here - #12221 (comment)

I'm strongly suggesting config.ordersTrackingData.hasOwnProperty('currency') instead of config.ordersTrackingData.length as a test for config.ordersTrackingData having values.

@torhoehn torhoehn mentioned this pull request Jun 4, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sidolov sidolov Awaiting requested review from sidolov

1 more reviewer

@dmanners dmanners dmanners approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dmanners dmanners

Labels

Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Projects

None yet

Milestone

January 2018

Development

Successfully merging this pull request may close these issues.

8 participants

@bhargavmehta @paddy194 @jschrab-lc @dmanners @magento-team @vkublytskyi @ishakhsuvarov @magento-engcom-team