Change of copyright year from 2017 to 2018. #13027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
ishakhsuvarov
requested changes
Jan 7, 2018
| @@ -1,5 +1,5 @@ | |||
| /** | |||
| * Copyright © 2013-2017 Magento, Inc. All rights reserved. | |||
Contributor
There was a problem hiding this comment.
Looks like this is an artifact form the previous copyright update.
Please change it to the one without specific year like in all other code files.
| @@ -1,5 +1,5 @@ | |||
| /** | |||
| * Copyright © 2013-2017 Magento, Inc. All rights reserved. | |||
| * Copyright © 2013-2018 Magento, Inc. All rights reserved. | |||
Contributor
There was a problem hiding this comment.
Looks like this is an artifact form the previous copyright update.
Please change it to the one without specific year like in all other code files.
| @@ -1,5 +1,5 @@ | |||
| /** | |||
| * Copyright © 2013-2017 Magento, Inc. All rights reserved. | |||
| * Copyright © 2013-2018 Magento, Inc. All rights reserved. | |||
Contributor
There was a problem hiding this comment.
Looks like this is an artifact form the previous copyright update.
Please change it to the one without specific year like in all other code files.
Contributor
|
This is not very dynamic or flexible in my opinion. I would either recommend the JS solution or the direct way with PHP. See http://updateyourfooter.com/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Have changed files for copyright.
#MM18IN
Manual testing scenarios