Skip to content

fixed issue prices aren't readable when using custom price symbol #13025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2018
Merged

fixed issue prices aren't readable when using custom price symbol #13025

merged 1 commit into from
Jan 18, 2018

Conversation

@pradeep-wagento
Copy link
Contributor

@pradeep-wagento pradeep-wagento commented Jan 7, 2018 •
edited by santhoshp
Loading

Frontend Works

Description

Updated currency addon css for bulk price html in configurable product

Fixed Issues (if relevant)

  1. While assigning prices to configurable products, prices aren's readable when using custom price symbol. #12430: While assigning prices to configurable products, prices aren's readable when using custom price symbol.

Manual testing scenarios

  1. Fresh Install
  2. Tested in all Modes
  3. Checked Static Content compile

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added mm18in Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jan 7, 2018
@rogyar rogyar self-assigned this Jan 12, 2018
@rogyar rogyar self-requested a review January 13, 2018 09:30
rogyar
rogyar approved these changes Jan 13, 2018
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thank you

@rogyar rogyar added this to the January 2018 milestone Jan 16, 2018
@magento-team magento-team mentioned this pull request Jan 18, 2018
Closed
magento-team pushed a commit that referenced this pull request Jan 18, 2018
MAGETWO-86781: fixed issue prices aren't readable when using custom p…
069184f 
…rice symbol #13025
@magento-team magento-team merged commit b3c0a3f into magento:2.2-develop Jan 18, 2018
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 18, 2018
@rogyar rogyar mentioned this pull request Apr 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rogyar rogyar rogyar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rogyar rogyar

Labels

Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Projects

None yet

Milestone

January 2018

Development

Successfully merging this pull request may close these issues.

4 participants

@pradeep-wagento @rogyar @magento-team @magento-engcom-team