Skip to content

Respect "Learn More Link" in Recently Viewed Products widget options #12946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2018
Merged

Respect "Learn More Link" in Recently Viewed Products widget options #12946

merged 1 commit into from
Jan 3, 2018

Conversation

@Jeroenll
Copy link
Member

@Jeroenll Jeroenll commented Jan 2, 2018 •
edited
Loading

Description

Learn More Link widget option in a Recently Viewed Products widget isn't respecting its setting.

Fixed Issues (if relevant)

  1. None

Manual testing scenarios

  1. Create Recently Viewed Products widget.
  2. In Widget Options > Product attributes to show, enable Name, Image and Price.
  3. On frontend the widget will also display the Learn More Link.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners dmanners self-assigned this Jan 2, 2018
@dmanners dmanners added this to the January 2018 milestone Jan 2, 2018
@Jeroenll Jeroenll mentioned this pull request Jan 2, 2018
Merged
4 tasks
magento-team pushed a commit that referenced this pull request Jan 3, 2018
@ishakhsuvarov
MAGETWO-86248: Respect "Learn More Link" in Recently Viewed Products …
7b54eca 
…widget options #12946
@magento-team magento-team merged commit 36ef0b4 into magento:2.2-develop Jan 3, 2018
@Jeroenll Jeroenll deleted the patch-3 branch January 4, 2018 08:40
@paales paales added Partner: Reach Digital Pull Request is created by partner Reach Digital and removed Partner: Reach Digital Pull Request is created by partner Reach Digital labels May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dmanners dmanners dmanners approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dmanners dmanners

Labels

Partner: Reach Digital Pull Request is created by partner Reach Digital Progress: accept Release Line: 2.2

Projects

None yet

Milestone

January 2018

Development

Successfully merging this pull request may close these issues.

4 participants

@Jeroenll @dmanners @magento-team @paales