Skip to content

Display a more meaningful error message in case of misspelt module name #12843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 15, 2018
Merged

Display a more meaningful error message in case of misspelt module name #12843

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef525e5
Display a more meaningful error message in case of misspelt module name.
Dec 21, 2017
ae3cbb9
Do not throw \LogicException, as it would break backwards-compatibility.
JanisE Dec 22, 2017
36268c6
Allow directory to be not set for non-module types.
JanisE Dec 22, 2017
196f691
Fix misspelling.
JanisE Dec 22, 2017
9c5975d
Simpler message, as this appears only for the modules themselves.
JanisE Dec 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/internal/Magento/Framework/Module/Dir.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ public function getDir($moduleName, $type = '')
{
$path = $this->componentRegistrar->getPath(ComponentRegistrar::MODULE, $moduleName);

// An empty $type means it's getting the directory of the module itself.
if (empty($type) && !isset($path)) {
// Note: do not throw \LogicException, as it would break backwards-compatibility.
throw new \InvalidArgumentException("Module '$moduleName' is not correctly registered.");
}

if ($type) {
if (!in_array($type, [
self::MODULE_ETC_DIR,
Expand Down