Skip to content

magento/magento2#4292: Ability to sitch to default mode #12752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2018
Merged

magento/magento2#4292: Ability to sitch to default mode #12752

merged 1 commit into from
Jan 5, 2018

Conversation

@Etty
Copy link

@Etty Etty commented Dec 15, 2017 •
edited by avoelkl
Loading

  • mode can be switched back to default w/o throving an error

Description

Fixed Issues (if relevant)

  1. Why can't one switch back to default mode ? #4292: Why can't one switch back to default mode ?

Manual testing scenarios

  1. Switch to developer mode php bin/magento deploy:mode:set developer
  2. Switch to default mode php bin/magento deploy:mode:set default

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 15, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added bugfix Area: Frontend mageconf Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 15, 2017
@Etty Etty requested a review from vkublytskyi December 15, 2017 14:51
@Etty
#4292: Ability to sitch to default mode
ba219b8 
- mode can be switched back to default w/o throving an error
@avoelkl avoelkl self-assigned this Dec 18, 2017
@avoelkl avoelkl added this to the January 2018 milestone Jan 4, 2018
@avoelkl
Copy link
Contributor

avoelkl commented Jan 4, 2018

Hi @Etty,
thanks for the PR!
I just tested it and it's working fine. Should be merged soon!

@magento-team magento-team mentioned this pull request Jan 5, 2018
Closed
@magento-team magento-team merged commit ba219b8 into magento:2.2-develop Jan 5, 2018
magento-team pushed a commit that referenced this pull request Jan 5, 2018
@ishakhsuvarov
MAGETWO-86337: #4292: Ability to sitch to default mode #12752
09cc206
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 5, 2018
@sidolov sidolov mentioned this pull request Apr 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@vkublytskyi vkublytskyi vkublytskyi approved these changes

@avoelkl avoelkl avoelkl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@avoelkl avoelkl

Labels

Area: Frontend bugfix Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Projects

None yet

Milestone

January 2018

Development

Successfully merging this pull request may close these issues.

6 participants

@Etty @magento-cicd2 @avoelkl @vkublytskyi @magento-team @magento-engcom-team