Skip to content

magento/magento2#12209: Substitution payment method - Incorrect message #12731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2018
Merged

magento/magento2#12209: Substitution payment method - Incorrect message #12731

merged 1 commit into from
Jan 9, 2018

Conversation

@zamoroka
Copy link
Member

@zamoroka zamoroka commented Dec 15, 2017 •
edited
Loading

  • fixed message showing if payment method is not available

Description

Also added check if method has title

Fixed Issues (if relevant)

  1. Substitution payment method - Incorrect message #12209: Substitution payment method - Incorrect message

Manual testing scenarios

Preconditions

  1. Magento 2.1.9 (same should be in 2.2-develop and 2.3-develop)
  2. DB migrated from M1, payment method wasn't migrated, so it's not available

Steps to reproduce

  1. Go to Admin panel and look at existing order
  2. View "Payment & Shipping Method" section

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@AndrewMun
magento#12209: Substitution payment method - Incorrect message
30b8293 
- fixed message showing if payment method is not available
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 15, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 15, 2017
@ishakhsuvarov
Copy link
Contributor

ishakhsuvarov commented Dec 15, 2017

Hi @zamoroka
Please sign the CLA with the email you have used for the commit.
Thank you!

@ishakhsuvarov ishakhsuvarov self-assigned this Jan 3, 2018
@ishakhsuvarov ishakhsuvarov added this to the January 2018 milestone Jan 3, 2018
@magento-team magento-team mentioned this pull request Jan 9, 2018
Closed
magento-team pushed a commit that referenced this pull request Jan 9, 2018
MAGETWO-86308: #12209: Substitution payment method - Incorrect message …
f6d2849 
…#12731
@magento-team magento-team merged commit 30b8293 into magento:2.2-develop Jan 9, 2018
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

+1 more reviewer

@vkublytskyi vkublytskyi vkublytskyi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ishakhsuvarov ishakhsuvarov

Labels

Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Projects

None yet

Milestone

January 2018

Development

Successfully merging this pull request may close these issues.

8 participants

@zamoroka @magento-cicd2 @ishakhsuvarov @vkublytskyi @ihor-sviziev @magento-team @magento-engcom-team @AndrewMun