[2.3-develop] Add customer login url from Customer Url model to checkout config so … #12631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2017 15:29
…it contains the referer url if necessary
magento-engcom-team
added
Reproduced on 2.1.x
dmanners
changed the title
Contributor
|
Backport for #12630 |
| /** | ||
| * @var UrlInterface | ||
| */ | ||
| protected $urlBuilder; |
Contributor
There was a problem hiding this comment.
You must deprecate it instead of remove.
| * @var UrlInterface | ||
| */ | ||
| protected $urlBuilder; | ||
| protected $customerUrl; |
Contributor
There was a problem hiding this comment.
New property must be private or public, in current case private.
| * @param ScopeConfigInterface $scopeConfig | ||
| */ | ||
| public function __construct( | ||
| UrlInterface $urlBuilder, |
Contributor
There was a problem hiding this comment.
According to Backward compatible development guide, you can't modify existing parameters. Add Url like optional parameter.
omiroshnichenko
suggested changes
Dec 13, 2017
Contributor
omiroshnichenko
left a comment
omiroshnichenko
left a comment
There was a problem hiding this comment.
Please, make this changes for all related PRs.
This was referenced Dec 13, 2017
Author
|
@omiroshnichenko Changes applied. |
| * @param UrlInterface $urlBuilder | ||
| * @param StoreManagerInterface $storeManager | ||
| * @param ScopeConfigInterface $scopeConfig | ||
| * @param Url $customerUrl |
Contributor
There was a problem hiding this comment.
$customerUrl also can be null.
| Url $customerUrl = null | ||
| ) { | ||
| $this->urlBuilder = $urlBuilder; | ||
| $this->urlBuilder=$urlBuilder; |
| $this->urlBuilder=$urlBuilder; | ||
| $this->storeManager = $storeManager; | ||
| $this->scopeConfig = $scopeConfig; | ||
| $this->customerUrl = $customerUrl ?? \Magento\Framework\App\ObjectManager::getInstance() |
Contributor
There was a problem hiding this comment.
Move ObjectManager to use instead of using fully qualified name.
magento-team
pushed a commit
that referenced
this pull request
Dec 20, 2017
… model to checkout config so … #12631
magento-engcom-team
added
the
Fixed in 2.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…it contains the referer url if necessary
Description
Use the url created in the customer model instead of creating a new one with the url builder. The current way isn't adding a referrer parameter when required
Fixed Issues (if relevant)
Manual testing scenarios
Redirect Customer to Account Dashboard after Logging inin the Magento backend.window.checkoutobject (key is customerLoginUrl)Contribution checklist