Skip to content

[Backport 2.1] Added Visibility and Status filter to category product grid #12576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Backport 2.1] Added Visibility and Status filter to category product grid #12576

wants to merge 2 commits into from

Conversation

@peterjaap
Copy link
Contributor

@peterjaap peterjaap commented Dec 7, 2017 •
edited
Loading

Add visibility and status filter to category product grid to be able to easier filter large amounts of products. Wading through thousands of 'Not visible individually' products is no fun.

Description

Before:
image

After:
image
& with filter applied;
image

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

This is a backport for 2.1 of #12564, ping @adrian-martinez-interactiv4

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Apr 5, 2018

Hi @peterjaap ,
Could you also backport following commit?
578e62c

@peterjaap
Copy link
Contributor Author

peterjaap commented May 22, 2018

@ihor-sviziev done!

ihor-sviziev
ihor-sviziev requested changes Jun 1, 2018
View reviewed changes
...ts/functional/tests/app/Magento/Catalog/Test/Constraint/AssertCategoryProductsGridFilter.php
@@ -0,0 +1,2083 @@

Copy link
Contributor

@ihor-sviziev ihor-sviziev Jun 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's mistake

Copy link
Contributor Author

@peterjaap peterjaap Aug 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ihor-sviziev what's a mistake?

Copy link
Contributor

@ihor-sviziev ihor-sviziev Aug 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just look at file contains. It looks like HTML

Copy link
Contributor Author

@peterjaap peterjaap Aug 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhh wow how did that get there. Ok I'll fix.

@sidolov sidolov removed the backport label Jul 31, 2018
@sidolov
Copy link
Contributor

sidolov commented Aug 7, 2018

Hi @peterjaap , will you continue progress with PR?

@sidolov sidolov self-assigned this Aug 8, 2018
@sidolov
Copy link
Contributor

sidolov commented Aug 28, 2018

Hi @peterjaap , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Aug 28, 2018
@peterjaap
Copy link
Contributor Author

peterjaap commented Aug 28, 2018

@sidolov not sure what still needs to be done?

@sidolov
Copy link
Contributor

sidolov commented Aug 28, 2018

@peterjaap please, check the comment from @ihor-sviziev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev requested changes

Assignees

@sidolov sidolov

@adrian-martinez-interactiv4 adrian-martinez-interactiv4

Labels

Progress: needs update Release Line: 2.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peterjaap @ihor-sviziev @sidolov @adrian-martinez-interactiv4