Issue: 3596. Resolve Notice with undefined index 'value' #12296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w order with instance payable method selected if custom offline payment method is defined in system
Author
|
That is the same as #12284, but for Magento 2.2 |
magento-team
pushed a commit
that referenced
this pull request
Nov 16, 2017
magento-team
pushed a commit
that referenced
this pull request
Nov 16, 2017
[EngCom] Public Pull Requests - 2.2-develop - MAGETWO-83959: Issue: 3596. Resolve Notice with undefined index 'value' #12296 - MAGETWO-83957: #12083: Cannot import zero (0) value into custom attribute #12283 - MAGETWO-83868: 11941: Invoice for products that use qty decimal rounds down to whole number. #11997
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue: #3596
Description
If you have a custom offline payment method it automatically falls in exception group used while fetching all payment methods this cause that payment method don't have value key in the definition and as the result - undefined index on order view page in admin panel. My fix adds key value as null and it fixes the notice.
Fixed Issues
Manual testing scenarios
Contribution checklist