Skip to content

Removed FileClassScannerTest dependency to "Magento_Catalog" #12144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2017
Merged

Removed FileClassScannerTest dependency to "Magento_Catalog" #12144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 31 additions & 6 deletions setup/src/Magento/Setup/Test/Unit/Module/Di/Code/Reader/FileClassScannerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,13 +204,38 @@ class ThisIsNotMyTest
self::assertContains('This\Is\Not\My\Ns\ThisIsNotMyTest', $result);
}

public function testClassKeywordInMiddleOfFile()
public function testMultipleClassKeywordsInMiddleOfFileWithStringVariableParsing()
{
$filename = __DIR__
. '/../../../../../../../../../..'
. '/app/code/Magento/Catalog/Model/ResourceModel/Product/Indexer/Eav/AbstractEav.php';
$filename = realpath($filename);
$scanner = new FileClassScanner($filename);
$scanner = $this->getMockBuilder(FileClassScanner::class)->disableOriginalConstructor()->setMethods([
'getFileContents'
])->getMock();
$scanner->expects(self::once())->method('getFileContents')->willReturn(<<<'PHP'
<?php

namespace This\Is\My\Ns;

use stdClass;

class ThisIsMyTest
{
protected function firstMethod()
{
$test = 1;
$testString = "foo {$test}";
$className = stdClass::class;
$testString2 = "bar {$test}";
}

protected function secondMethod()
{
$this->doMethod(stdClass::class)->runAction();
}
}

PHP
);

/* @var $scanner FileClassScanner */
$result = $scanner->getClassNames();

self::assertCount(1, $result);
Expand Down