[Backport 2.1] #11825: Generate new FormKey and replace for oldRequestParams Wishlist

[osrecio]

Generate new FormKey afterLogin and set to the beforeRequest(Wishlist)

Description

Generate new FormKey afterLogin and set to the beforeRequest(Wishlist)

Fixed Issues (if relevant)

1. 2.1.9 Item not added to the Wishlist if the user is not logged at the moment he click on the button to add it. #11825: 2.1.9 Item not added to the Wishlist if the user is not logged at the moment he click on the button to add it
2. Adding to wishlist doesn't work when not logged in #11908: Adding to wishlist doesn't work when not logged in

Manual testing scenarios

1. Create an user account.
2. Logout from the user account
3. Add a product to your Wishlist , you will get redirected to the login page
4. Login

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[vkublytskyi]

@osrecio tests failed as this fix introduces dependency for PageCache on Customer module. We should avoid this for bugfixes. Also we should avoid this as Customer module already has a dependency on PageCashe module and we must avoid circular dependencies. As a solution, I may suggest make a plugin on \Magento\PageCache\Observer\FlushFormKey in a customer module

[osrecio]

Hi @vkublytskyi I added a Plugin in Customer Module to make the same logic.

[vkublytskyi]

Please add @SuppressWarnings(PHPMD.UnusedFormalParameter) to avoid static tests failure

[vkublytskyi]

Please set copyright same as in other files for 2.1-develop:

/**
 * Copyright © 2013-2017 Magento, Inc. All rights reserved.
 * See COPYING.txt for license details.
 */

[osrecio]

Changed by:

/**
 * Copyright © 2013-2017 Magento, Inc. All rights reserved.
 * See COPYING.txt for license details.
 */

[vkublytskyi]

Please do not modify copyright.

[osrecio]

@vkublytskyi Added param @SuppressWarnings(PHPMD.UnusedFormalParameter) but still failing :(

[ihor-sviziev]

@osrecio please add following line to phpdoc block * @return void, it should fix static tests. Also in 2.2 and 2.3 you already have unit tests. Please add it there

[vkublytskyi]

@osrecio I've pushed commit with fixed static test and backport of unit test. Please take a look to fix in unit test to solve an issue with an incorrect value passed to aroundExecute in original test from 2.2. Please fill free to squash my commit and force push branch to clean up git history.