Skip to content

Fix #2156 Js\Dataprovider uses the RendererInterface. #12007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 26, 2017
Merged

Fix #2156 Js\Dataprovider uses the RendererInterface. #12007

merged 1 commit into from
Dec 26, 2017

Conversation

dverkade
Copy link
Member

@dverkade dverkade commented Nov 3, 2017

Description

Fixed Issues

  1. Why does \Magento\Translation\Model\Js\DataProvider use \Magento\Framework\Phrase\Renderer\Translate, not \Magento\Framework\Phrase\Renderer\Composite? #2156: Why does \Magento\Translation\Model\Js\DataProvider use \Magento\Framework\Phrase\Renderer\Translate, not \Magento\Framework\Phrase\Renderer\Composite?

@dverkade
- Fix #2156 changed dataprovider constructor to the RendererInterface
db0c775 
- Changed InlineTest, which has an Inline class object and not a Translate class object
@magento-engcom-team magento-engcom-team added 2.2.x bugfix Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Nov 7, 2017
@ihor-sviziev ihor-sviziev self-assigned this Nov 10, 2017
@ihor-sviziev ihor-sviziev added Release Line: 2.2 Progress: accept Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 10, 2017
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Nov 10, 2017 •
edited
Loading

@dverkade could you please create the same PR to 2.1-develop and 2.2-develop branches?

@okorshenko okorshenko removed the 2.2.x label Dec 14, 2017
@okorshenko okorshenko self-assigned this Dec 22, 2017
@okorshenko okorshenko added this to the December 2017 milestone Dec 22, 2017
@okorshenko okorshenko mentioned this pull request Dec 26, 2017
Closed
@magento-team magento-team merged commit db0c775 into magento:2.3-develop Dec 26, 2017
magento-team pushed a commit that referenced this pull request Dec 26, 2017
MAGETWO-85958: Fix #2156 Js\Dataprovider uses the RendererInterface. #…
a107dbf 
…12007
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Dec 26, 2017
This was referenced Jan 2, 2018
Merged
Merged
@dverkade dverkade deleted the Change_Js_Dataprovider branch June 22, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@okorshenko okorshenko

Labels
bugfix Fixed in 2.3.x The issue has been fixed in 2.3 release line Progress: accept Release Line: 2.3 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
December 2017
Development

Successfully merging this pull request may close these issues.
5 participants
@dverkade @ihor-sviziev @magento-team @okorshenko @magento-engcom-team