Skip to content

Conversation

@adrian-martinez-interactiv4
Copy link
Contributor

Preinstalled xml layout update handle in Home Page is invalid, element action is not expected anymore under referenceContainer node:
captura de pantalla 2017-10-30 a las 1 02 34

captura de pantalla 2017-10-30 a las 1 03 01

Exception handling for this validation will be done when changes from PR #11857 are applied.

Description

This legacy code shows a demo of how can be removed right.reports.product.viewed and right.reports.product.compared from right column, but it is outdated; the instructions are not valid and referenced blocks have changed.

This PR suggest changing that preinstalled layout update handle, adapting reference to compared block and removing the viewed block reference, since this last one is now handled via widget and is not at the right column by default, so there is no need to try to remove it:

<referenceContainer name="right">
    <referenceBlock name="catalog.compare.sidebar" remove="true" />
</referenceContainer>

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners
Copy link
Contributor

dmanners commented Nov 1, 2017

Will put this on hold until #11863 has been merged.

@dmanners dmanners added this to the November 2017 milestone Nov 30, 2017
@magento-team magento-team merged commit 5d5f633 into magento:2.3-develop Dec 14, 2017
magento-team pushed a commit that referenced this pull request Dec 14, 2017
magento-team pushed a commit that referenced this pull request Dec 14, 2017
[EngCom] Public Pull Requests - develop
 - MAGETWO-84811: [Backport 2.3-develop] Update wrong layout update xml handle installed in CMS Home Page by default #11891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants