CMS Page - Force validate layout update xml, even in production mode, when saving CMS Page #11865
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving custom layout update xml in CMS page, in production mode, xml is not validated against schema file, due to
\Magento\Framework\App\Arguments\ValidationState::isValidationRequiredmethod:Actual result:


Desired behaviour would be check the layout update xml against the schema, and show error message to the user if it is invalid:

Description
\Magento\Cms\Model\Page\DomValidationStatehas been added, and it is injected from post data processor to force layout update xml validation, only upon cms page save.When this PR is applied and validation is performed, application may crush due to unhandled exception. This issue is solved by PR #11857
Manual testing scenarios
Contribution checklist