Skip to content

Set condition for Tier price block. #11835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Set condition for Tier price block. #11835

wants to merge 2 commits into from

Conversation

RakeshJesadiya
Copy link
Contributor

@RakeshJesadiya RakeshJesadiya commented Oct 28, 2017

Issue arise only after upgrade from Magento 2.1 to Magento 2.2.0
After Upgrade From Magento 2.1.3 to Magento 2.2.0,
In configurable product page, when change variant option value from dropdown box, Tier price block section will display as null above the dropdown option list.
So try to remove those box for product doenst have tier price after debuging got solution from configurable.js file.
If product variant with tier price, Its display block for tier price if product with no tier price its display blank box.

Check for below image with issue,
config-tier
Blank tier price box will display.

Issue arise only after upgrade from Magento 2.1 to Magento 2.2.0
After Upgrade From Magento 2.1.3 to Magento 2.2.0,
In configurable product page, when change variant option value from dropdown box, Tier price block section will display as null above the dropdown option list.
So try to remove those box for product doenst have tier price after debuging got solution from configurable.js file.
If product variant with tier price, Its display block for tier price if product with no tier price its display blank box.
@avoelkl
Copy link
Contributor

avoelkl commented Nov 2, 2017

Hi @RakeshJesadiya! Can you please reformat your description to match the template?
Also please have a look at the failing Travis tests. Thanks!

@ArthurTransoftgroup
Copy link

ArthurTransoftgroup commented Nov 30, 2017

@RakeshJesadiya can you help please with the testing of this PR? Here is a video of how it been tested, but issue can't be reproduced. I used this command for Magento upgrade in command line:
php bin/magento indexer:reindex && php bin/magento cache:flush && git checkout 2.2.0 && composer install && php bin/magento setup:upgrade && php bin/magento cron:run && php bin/magento cron:run && php bin/magento cache:clean
test.zip

@okorshenko
Copy link
Contributor

Hi @RakeshJesadiya thank you for your contribution. I'm closing this PR due to inactivity. Feel free to reopen it once ready

@okorshenko okorshenko closed this Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants