Product attribute creation page handles Storefront tab visibility wrong #11770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 26, 2017 12:59
…ut types with hidden fields y
…ut types with hidden fields with (Magento_Swatches enabled) y
Contributor
|
|
dmanners
suggested changes
Oct 30, 2017
Contributor
dmanners
left a comment
dmanners
left a comment
There was a problem hiding this comment.
Update to variable naming to remove the _
|
|
||
| <?php foreach ($this->helper('Magento\Catalog\Helper\Data')->getAttributeHiddenFields() as $type => $fields): ?> | ||
| case '<?= /* @escapeNotVerified */ $type ?>': | ||
| var is_front_tab_hidden = false; |
Contributor
There was a problem hiding this comment.
Could you change this variable to isFrontTabHidden to match the rest of the file.
dmanners
approved these changes
Oct 30, 2017
magento-team
added
Progress: needs update
Progress: accept
and removed
Progress: needs update
labels
magento-team
pushed a commit
that referenced
this pull request
Nov 6, 2017
… visibility wrong #11770
magento-team
pushed a commit
that referenced
this pull request
Nov 6, 2017
[EngCom] Public Pull Requests - 2.2-develop - MAGETWO-83278: Add validation for number of street lines #12013 - MAGETWO-83277: [backport 2.2] Magento 2 Store Code validation regex: doesn't support uppercase letters in store code #12011 - MAGETWO-82991: Product attribute creation page handles Storefront tab visibility wrong #11770 - MAGETWO-82976: Update wrong layout update xml handle installed in CMS Home Page by d… #11863 - MAGETWO-82952: Check attribute unique between same fields in magento commerce #11620
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With or without Swatches module, the Storefront tab is not showing up if it was hidden earlier and the current attribute type has some hidden fields.
The fix contains both the solution for Magento_Catalog and Magento_Swatches.
Manual testing scenarios
For the testing you should install a third party module (like https://github.com/PartBerlin/Decimal)
Steps:
Scenario A: without Magento_Swatches
Scenario B: with Magento_Swatches
Contribution checklist