Skip to content

Conversation

adrian-martinez-interactiv4
Copy link
Contributor

Description

Installing or removing crontab via command adds 2>&1 repeatedly, even for crontab entries not related with Magento, if they match a regular expression. See details in #11586.

Fixed Issues (if relevant)

  1. Cron install / remove via command messes up stderr 2>&1 entries #11586: Cron install / remove via command messes up stderr 2>&1 entries

Manual testing scenarios

As explained in #11586

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur orlangur self-assigned this Oct 20, 2017
@orlangur orlangur added this to the October 2017 milestone Oct 23, 2017
@orlangur orlangur added Release Line: 2.1 2.2.x Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Fixed in 2.2.x The issue has been fixed in 2.2 release line labels Oct 23, 2017
@orlangur
Copy link
Contributor

Hi @adrian-martinez-interactiv4, a small note on copyright header - it should be consistent across all files in corresponding version, so, for 2.1.x there should still be year. It is enforced by tests running internally on Bamboo.

No action required from your side, I was wondering how GitHub UI editing looks like in action :)

@adrian-martinez-interactiv4
Copy link
Contributor Author

@orlangur I saw you changed that, and I realized I should have respected the headers :D

@okorshenko okorshenko merged commit 4478cf4 into magento:2.1-develop Oct 27, 2017
okorshenko pushed a commit that referenced this pull request Oct 27, 2017
@adrian-martinez-interactiv4 adrian-martinez-interactiv4 deleted the FR21#CRON-INSTALL-PARSE-STDERR branch October 27, 2017 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Award: test coverage Fixed in 2.2.x The issue has been fixed in 2.2 release line Release Line: 2.1 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants