Skip to content

Conversation

@niccifor
Copy link

@niccifor niccifor commented Sep 28, 2017

Description

There were 2 missing return statements in
Magento\Sales\Model\Order\Shipment\ItemCreation setters.

This brakes "fluent interface" suggested in its interface.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@vrann vrann self-assigned this Sep 29, 2017
@vrann vrann added this to the September 2017 milestone Sep 29, 2017
@vrann vrann reopened this Sep 29, 2017
@okorshenko okorshenko merged commit 7d5fc25 into magento:2.2-develop Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants