Skip to content

Added getter and setter on store model and interface #11077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

hervebackstage
Copy link

Added getter and setter on store model and interface

Description

this change gives the node is_active available to the API call rest/default/V1/store/storeViews

heyitsroberthe and others added 4 commits September 12, 2017 20:36
[mpi] MAGETWO-72551: Update version in composer to 2.2.1-dev for 2.2-develop branch
the isActive getter/setter were missing and these made the API call storeViews having not the is_active data
added getter and setter to make isActive node available in API storeView call
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 26, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ hervebackstage
❌ paliarush
❌ viktym

@orlangur
Copy link
Contributor

orlangur commented Sep 26, 2017

Please sign CLA and check review notes in #10923.

@orlangur
Copy link
Contributor

orlangur commented Oct 12, 2017

Closing in favor of earlier PR with the same approach which was decided to be merged as is.

@hervebackstage thanks for collaboration!

@orlangur orlangur closed this Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants