Skip to content

Only prompt for deploy command in production mode #11047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2017
Merged

Only prompt for deploy command in production mode #11047

merged 1 commit into from
Oct 16, 2017

Conversation

@schmengler
Copy link
Contributor

@schmengler schmengler commented Sep 26, 2017

Description

After running setup:upgrade command, the message "Please rerun Magento compile command" only shows up in production mode

Fixed Issues (if relevant)

  1. magento setup:upgrade prompts to run compilation, even in developer mode #11044: magento setup:upgrade prompts to run compilation, even in developer mode

Manual testing scenarios

  1. run bin/magento setup:upgrade in developer or default mode

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@schmengler schmengler changed the base branch from develop to 2.2-develop September 26, 2017 10:11
@schmengler schmengler changed the base branch from 2.2-develop to develop September 26, 2017 10:11
@schmengler schmengler mentioned this pull request Sep 26, 2017
Merged
4 tasks
@dmanners dmanners mentioned this pull request Sep 29, 2017
Closed
4 tasks
@mzeis mzeis requested review from magento-engcom-team and removed request for magento-engcom-team October 6, 2017 18:06
@dmanners dmanners self-assigned this Oct 11, 2017
@dmanners dmanners added this to the October 2017 milestone Oct 11, 2017
dmanners
dmanners approved these changes Oct 11, 2017
View reviewed changes
Copy link
Contributor

@dmanners dmanners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I will start processing this now for you.

@magento-team magento-team merged commit 09af556 into magento:develop Oct 16, 2017
magento-team pushed a commit that referenced this pull request Oct 16, 2017
@vrann
MAGETWO-81618: Only prompt for deploy command in production mode #11047
d3e0a7b
@keharper keharper mentioned this pull request Jun 8, 2018
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dmanners dmanners dmanners approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dmanners dmanners

Labels

Component: Setup Progress: accept

Projects

None yet

Milestone

October 2017

Development

Successfully merging this pull request may close these issues.

4 participants

@schmengler @dmanners @magento-team @magento-engcom-team