Skip to content

Conversation

@duckchip
Copy link
Contributor

@duckchip duckchip commented Sep 22, 2017

This fixes an issue with finding the template when creating a preference for Magento\Checkout\Block\Cart\Item\Renderer

Manual testing scenarios

  1. ... create a preference for Magento\Checkout\Block\Cart\Item\Renderer

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@duckchip duckchip changed the title fix for overwriting the cart item template fix for lost template when creating a preference for Magento\Checkout\Block\Cart\Item\Renderer Sep 22, 2017
@dmanners
Copy link
Contributor

Hi @duckchip thanks for this PR. From what I can see this change has already been made in the develop branch. Was this the desired branch or did you want to back port this fix to a particular version? https://github.com/magento/magento2/blob/develop/app/code/Magento/Checkout/view/frontend/layout/checkout_cart_item_renderers.xml#L12

@dmanners
Copy link
Contributor

Otherwise if you just need to update your fork have a look through the GitHub docs about keeping your fork up to day. https://help.github.com/articles/syncing-a-fork/ Just make sure you are on the right branch when doing merges.

@dmanners
Copy link
Contributor

dmanners commented Oct 5, 2017

@duckchip, we are closing this PR as the changes are already on the develop branch. If you'd like to update it or change the target branch, please create a new pr with the updated code.

@dmanners dmanners closed this Oct 5, 2017
@hostep
Copy link
Contributor

hostep commented Oct 5, 2017

Just informational, the correct solution would be to backport b4005c5 or use the same search-and-replace method @davidalger used, but then on the 2.1-develop branch to fix this properly.

If someone feels like doing this, be my guest :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants