Skip to content

Conversation

@vovayatsyuk
Copy link
Member

@vovayatsyuk vovayatsyuk commented Sep 8, 2017

Description

PayPal express pop-up stays opened when the 'setPaymentMethodAction' request was rejected.

Manual testing scenarios

  1. Trigger an error on the server side for the set-payment-information action
  2. Place an order using PayPal Express in-context mode.
  3. Popup will stay opened and the whole screen dimmed.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov ishakhsuvarov self-assigned this Sep 8, 2017
@ishakhsuvarov ishakhsuvarov added this to the September 2017 milestone Sep 8, 2017
@magento-team magento-team merged commit 2b318c3 into magento:develop Sep 13, 2017
magento-team pushed a commit that referenced this pull request Sep 13, 2017
[EngCom] Public Pull Requests
 - MAGETWO-72486: response condition order changes. #10826
 - MAGETWO-72465: Enable livereload for watch: commands #10836
 - MAGETWO-72428: Close PayPal popup window in case of rejected request #10820
@gwharton
Copy link
Contributor

gwharton commented Nov 8, 2017

@vovayatsyuk Can we get this one backported into 2.2?

@vovayatsyuk
Copy link
Member Author

Yep, I will create a backport PR shortly

okorshenko pushed a commit that referenced this pull request Nov 9, 2017
…jected request #10820 #12131

 - Merge Pull Request #12131 from vovayatsyuk/magento2:fix-opened-paypal-express-in-context-popup-2.2
 - Merged commits:
   1. f19fa30
okorshenko pushed a commit that referenced this pull request Nov 9, 2017
Public Pull Requests

#12139 9768: Admin dashboard Most Viewed Products Tab only gives default attribute set's products(backport for 2.2) by @RomaKis
#12131 [Backport 2.2] Close PayPal popup window in case of rejected request #10820 by @vovayatsyuk
#12082 Products in cart report error when we have grouped or bundle product by @mihaifaget
#11719 10920: Sku => Entity_id relations are fetched inefficiently when inserting attributes values during product import. by @nmalevanec
#12031 Improve urn in xhtml by @enriquei4
#11988 10195: Order relation child is not set during edit operation(backport from 2.3 to 2.2) by @RomaKis
#11962 11793: Magento2.1.5 admin shipping report shows wrong currency code by @RomaKis
#11947 Fix json encoded attribute backend type when attribute value is null by @tkotosz
#11902 #9151: [Github] Sitemap.xml: lastmod timestamp can contain invalid dates by @serhii-balko
#11857 CMS Page - CMS Page - Force validate layout update xml in production mode when saving CMS Page - Handle layout update xml validation exceptions by @adrian-martinez-interactiv4
#11722 6802: Magento\Search\Helper\getSuggestUrl() not used in search template. by @nmalevanec
#11461 [ISSUE-10811][BUGFIX] Update .htaccess.sample to replace FollowSymLin… by @diglin

Fixed Public Issues

#9768 Admin dashboard Most Viewed Products Tab only gives default attribute set's products
#12079 Products in cart report error when we have grouped or bundle product
#10920 Sku => Entity_id relations are fetched inefficiently when inserting attributes values during product import
#6661 XHTML templates Don't Use Schema URNs
#10195 Order relation child is not set during edit operation.
#11793 Magento2.1.5 admin shipping report shows wrong currency code
#9151 Sitemap.xml: lastmod timestamp can contain invalid dates
#6802 Magento\Search\Helper\getSuggestUrl() not used in search template
#10811 Replace FollowSymLinks with SymLinksIfOwnerMatch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants