Skip to content

Fix: Move GitHub-specific documents into .github #10778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2017

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Sep 5, 2017

Description

As lined out at https://github.com/blog/2111-issue-and-pull-request-templates:

If you're worried about the added clutter in the root directory of your project, we also added support for a .github/ folder. You can put CONTRIBUTING.md, ISSUE_TEMPLATE.md, and PULL_REQUEST_TEMPLATE.md files in .github/ and everything will work as expected.

this PR moves files specific to GitHub into .github/.

💁‍♂️ I am unaware whether these changes affect any external pages linking to these documents, but these changes will definitely work fine here on GitHub.

Fixed Issues (if relevant)

n/a

Manual testing scenarios

n/a

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur orlangur self-assigned this Sep 5, 2017
@orlangur orlangur added this to the September 2017 milestone Sep 5, 2017
@orlangur
Copy link
Contributor

orlangur commented Sep 5, 2017

Great! This item was in my TODO list since I saw the corresponding GitHub blog post (or maybe it was some angular repo?).

But there is small thing to do yet. Please grep all over the code or these files occurrences and change them accordingly (at least there were some in root .htaccess) and make this new folder inaccessible like https://github.com/magento/magento2/blob/develop/vendor/.htaccess (or maybe dot folders are restricted by default? don't have Apache in my hand to check...)

@magento-team magento-team merged commit 327c26d into magento:develop Sep 6, 2017
magento-team pushed a commit that referenced this pull request Sep 6, 2017
[EngCom] Public Pull Requests
 - MAGETWO-72350: Fix: Use all columns when running tests #10784
 - MAGETWO-72349: Fix: Move GitHub-specific documents into .github #10778
 - MAGETWO-72344: Enhancement: Configure preferred installation source in composer.json #10774
 - MAGETWO-72279: Always use https for Vimeo video's. #10768
@localheinz localheinz deleted the fix/github branch September 6, 2017 19:44
@localheinz
Copy link
Contributor Author

localheinz commented Sep 6, 2017

Thank you, @magento-team and @orlangur!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants