Skip to content

Translate password field placeholder in Checkout #10056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2017
Merged

Translate password field placeholder in Checkout #10056

merged 1 commit into from
Jun 26, 2017

Conversation

@mimarcel
Copy link
Contributor

@mimarcel mimarcel commented Jun 26, 2017 •
edited by ishakhsuvarov
Loading

Description

Translate placeholder

Manual testing scenarios

  1. Open Guest Mode browsing
  2. Go to checkout
  3. Enter the email address of a customer which already exists

Expected:
Placeholder is translated.

Actual:
Placeholder is not translated.
checkout

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@mimarcel mimarcel changed the title Translate placeholder Translate password field placeholder in Checkout Jun 26, 2017
@ishakhsuvarov ishakhsuvarov self-assigned this Jun 26, 2017
@ishakhsuvarov ishakhsuvarov added this to the June 2017 milestone Jun 26, 2017
@magento-team magento-team merged commit ee0af7a into magento:develop Jun 26, 2017
magento-team pushed a commit that referenced this pull request Jun 26, 2017
MAGETWO-70235: Translate password field placeholder in Checkout #10056
03c279a
@mimarcel mimarcel deleted the fix/translate_checkout_password_placeholder branch June 27, 2017 07:46
@Jeroenll Jeroenll mentioned this pull request Oct 16, 2017
Merged
4 tasks
@quisse quisse mentioned this pull request Apr 11, 2018
Closed
magento-devops-reposync-svc pushed a commit that referenced this pull request Sep 3, 2025
@glo71317
Merge pull request #10056 from magento-gl/spartans_pr_29082025
a3b1abc 
[Spartans] BugFixes Delivery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ishakhsuvarov ishakhsuvarov

Labels

None yet

Projects

None yet

Milestone

June 2017

Development

Successfully merging this pull request may close these issues.

3 participants

@mimarcel @magento-team @ishakhsuvarov