js-translation.json not picking up theme translations 2.1.3 / 2.1.4

[tadhgbowe]

Hello. Apologies is reported before. I couldn't see it.

My theme translation file is not appearing in certain locations. For example the mini cart overlay and the cart is empty it says "You have no items in your shopping cart."

In my theme I have the translation "You have no items in your shopping basket.". When I go to the cart page I can see underneath the main content title "You have no items in your shopping basket.". So I know it's working. However when I hover over the mini cart in the header the overlay continues to say "You have no items in your shopping cart."

Tried on 2.1.3 and 2.1.4 community edition.

I have tried a static deploy, deleted the js-translation.json file itself. No joy.

Question: Does the js-translation.json not pick up theme translations?

Preconditions

Locale set to en_GB - English (United Kingdom)
Create a new theme. Enable this in the backend via Content > Design - Configuration.
Create a i18n/en_GB.csv file with the above translation:
"You have no items in your shopping cart.","You have no items in your shopping basket."
Refresh block, page and translation caches.

Steps to reproduce

Go to cart page /onepage/cart. In the main content area underneath Shopping Cart I can see my translation "You have no items in your shopping basket.". However the mini-cart overlay doesn't display the new translation.

Expected result

The empty mini-cart overlay should translate to "You have no items in your shopping basket."

Actual result

The empty mini-cart overlay continues to display the core translation "You have no items in your shopping cart."

OTHER NOTES/OBSERVATIONS/TESTS:

• If I create a language pack it does work! Curious. So why does it not pick up theme translations? This could be a bug I guess?

Thanks
T

[tadhgbowe]

Update on this (spent all day debugging):

• When you clear the translation cache and remove the js-translation.json file from your theme in pub/static/frontend/Magento/[your theme]/[your locale]/js-translation.json it will try to rebuild.

• vendor/magento/framework/Translate.php is where all the main work occurs.

• What I've found is when it starts to rebuild the js-translation.json (which starts from
  vendor/magento/module-translation/Model/Json/PreProcessor.php) it comes to vendor/magento/framework/Translate.php and it's not able to evaluate the theme for the config setting:

$this->_config['theme'] = $this->_viewDesign->getDesignTheme()->getId(); returns null.

So in the function _loadThemeTranslation() it fails because $this->_config['theme'] is not set (it's null). It should be returning the theme Id (in my case ID 4).

So there's something the matter with
\Magento\Framework\View\DesignInterface $viewDesign in the constructor.

Hope this helps. Is there a quick workaround I wonder?

Thanks
Tadhg

[thomvanderboon]

Duplicate of #8459

Thom

[Flamestyle]

Hello! Please write your steps and commands for two methods: create language pack and create theme translations.

[tadhgbowe]

Hello.
Thanks for the feedback. I did see #8459 and #7862 but this issue I believe is an additional problem.

I have also experienced the js-translation.json not building itself properly. Deleting the file does rebuild it but still fails to pick up theme translations (not 100% sure a "bin/magento setup:static-content:deploy..." works on my custom theme).

I have no idea what is meant by "Please write your steps and commands for two methods: create language pack and create theme translations".

I have noticed some quite short and disrespectful comments on GitHub. I can appreciate people's frustration but that isn't going to solve anything. I've given up valuable company time to try highlight this particular problem.

I haven't tested in versions previous to 2.1.3. I will try do this tomorrow.

Thanks
T :-)

[Flamestyle]

I see the same problem, but all commands are executed too different. So I asked to write all the steps that you did when deploying the language.
I try 2 methods:
Method 1: Create a language package same official docs, create 4 files: composer.json, language.hml, registration.php, ru_RU.csv.
After make this commands:

cd /var/www/html
rm -rf pub/static/*
rm -rf var/view_preprocessed/*
php /var/www/html/bin/magento cache:clean
bin/magento setup:static-content:deploy --theme Magento/backend en_US
bin/magento setup:static-content:deploy --theme Agestor/default ru_RU
php /var/www/html/bin/magento cache:clean

Method 2: Add file ru_RU.csv to my theme. Path: app/design/frontend/Agestor/default/i18n/.
After make this commands:

cd /var/www/html
rm -rf pub/static/*
rm -rf var/view_preprocessed/*
php /var/www/html/bin/magento cache:clean
bin/magento setup:static-content:deploy --theme Magento/backend en_US
bin/magento setup:static-content:deploy --theme Agestor/default ru_RU
php /var/www/html/bin/magento cache:clean

Right?

Two methods same official documentation. Don't works... js-translation.json - empty...
Thanks!

[tadhgbowe]

Hi Flamestyle / All.

You look to be doing everything correctly. I'm assuming you've set your Locale (In Stores > Configuration > General - Locale) to ru_RU?

However in my case the language pack is being picked up and the js-translation.json is not empty.

My Locale is set to en_GB. The code in my language.xml is set to en_GB.

It's the Theme translations that I want to pick up in my js-translation.json i.e.
app/design/frontend/<your_vendor_name>/<your_theme_name>/i18n/en_GB.csv

AND I THINK I'VE FOUND THE PROBLEM TO MY ISSUE:

In vendor/magento/module-translation/Model/Json/PreProcessor.php

        $area = $this->areaList->getArea($areaCode);
        $area->load(\Magento\Framework\App\Area::PART_TRANSLATE);

needs to be:

        $area = $this->areaList->getArea($areaCode);
        $area->load(\Magento\Framework\App\Area::PART_DESIGN);
        $area->load(\Magento\Framework\App\Area::PART_TRANSLATE);

It needs to load the design before loading the translations. The above insertion then works for me! So hopefully Magento will pick up on this soon.

When you look at how other areas are loaded for example:
vendor/magento/framework/View/DesignLoader.php

You'll see:

$area = $this->_areaList->getArea($this->appState->getAreaCode());
$area->load(\Magento\Framework\App\Area::PART_DESIGN);
$area->load(\Magento\Framework\App\Area::PART_TRANSLATE);

The design must be present before the translations are loaded.

Thanks
Tadhg

[Flamestyle]

@tadhgbowe, yes General - Locale include ru_RU.
I have one question: you use method 1 or 2? I see you use file en_GB.csv app/design/frontend/[THEME]/default/i18n/en_GB.csv, but you write more about language.xml. So you use 2 methods together?
Thank you!

[tadhgbowe]

Hello again,

I only created the language pack to see if my js-translation.json could pick up the translations from there. And yes that worked. But I never wanted to create a language pack. I simply wanted to be able to handle everything from my theme.

So in my example I can now remove the language pack. I only used it to prove that js translations worked when in a language pack and not from my theme.

My theme code (in database table theme) is called Training/default. If I run all the following commands it works fine:

rm -rf pub/static/*
rm -rf var/view_preprocessed/*
php /var/www/html/bin/magento cache:clean
bin/magento setup:static-content:deploy --theme Training/default en_GB

Please Note: When you setup a theme you can't just have an i18n folder and nothing else. The static-content:deploy will error saying that the Theme doesn't exist. You have to have some wee/css/source files in there for it to deploy for you.

Thanks
Tadhg

[Flamestyle]

Hello, @tadhgbowe! For me prefer to be able to handle everything from my theme too.
Your solution $area->load(\Magento\Framework\App\Area::PART_DESIGN); works!
Thank you so much!

[tadhgbowe]

Hi @Flamestyle and all others who read this.

Obviously this is a small Magento bug and hopefully they will pick up on this soon.

We can't change the core file vendor/magento/module-translation/Model/Json/PreProcessor.php for obvious reasons. For a workaround you can consider using a before Plugin, a Preference or as you'll see below the PreProcessor is already a part of the module-translation di.xml.

In your code/[Vendor]/[Module Name]/etc/di.xml you can use:

1. Preference:

<preference for="Magento\Translation\Model\Json\PreProcessor" type="[Vendor]/[Module Name]\Model\Json\PreProcessor"/>

2. before Plugin (preferred choice):

<type name="Magento\Translation\Model\Json\PreProcessor"> <plugin name="pluginTranslationJsonExtra" type="[Vendor]/[Module Name]\Plugin\Json\PreProcessor" sortOrder="10" disabled="false"/> </type>

3. intercept existing module-translation di.xml AssetPreProcessorPool:

<virtualType name="AssetPreProcessorPool"> <arguments> <argument name="preprocessors" xsi:type="array"> <item name="json" xsi:type="array"> <item name="json_generation" xsi:type="array"> <item name="class" xsi:type="string">[Vendor]/[Module Name]\Model\Json\PreProcessor</item> </item> </item> </argument> </arguments> </virtualType>

All the best,
Tadhg

[12impress]

I have the same problem. But this fix doesn't work for me....

[Flamestyle]

@carfantasy Which of the two? Write all your steps so that can analyze.

[12impress]

Hi,
This is my issue and also the minicart issue:
#8337

I did:
composer update
php bin/magento setup:upgrade
php bin/magento cache:clean
php bin/magento setup:di:compile
rm -rf pub/static/*
rm -rf var/view_preprocessed/*
php /var/www/html/bin/magento cache:clean
bin/magento setup:static-content:deploy --theme Magento/backend en_US
bin/magento setup:static-content:deploy --theme (theme)/default nl_NL
php /var/www/html/bin/magento cache:clean

this was not the solution, so I did:

In vendor/magento/module-translation/Model/Json/PreProcessor.php

    $area = $this->areaList->getArea($areaCode);
    $area->load(\Magento\Framework\App\Area::PART_TRANSLATE);

needs to be:

    $area = $this->areaList->getArea($areaCode);
    $area->load(\Magento\Framework\App\Area::PART_DESIGN);
    $area->load(\Magento\Framework\App\Area::PART_TRANSLATE);

rm -rf pub/static/*
rm -rf var/view_preprocessed/*
php /var/www/html/bin/magento cache:clean
bin/magento setup:static-content:deploy --theme Magento/backend en_US
bin/magento setup:static-content:deploy --theme (theme)/default nl_NL
php /var/www/html/bin/magento cache:clean

Still not the solution....

[tadhgbowe]

Hi @carfantasy,

First you need to check that your Stores > Configuration > General > Locale Options : the Locale for you needs to be set to Dutch (Netherlands).

Secondly you need to make sure that your theme has the correct i18n/nl_NL.csv file. So it should live in a folder like app/design/frontend/[Theme/Vendor namespace]/[Theme e.g. default]/i18n

With all the caches enabled you should only need to refresh the translations cache. You can also simply delete the js-translation.json in your pub/static/frontend/[Theme/Vendor namespace]/[Theme]/nl_NL folder.

When the page loads (for example the basket page), there should be a call to build the js-translation.json.

If it's not generating a js-translation.json at all then I would stick on some debug in vendor/magento/module-translation/Model/Json/PreProcessor.php process function. It should go in here. If it isn't then that's another Magento bug. I've never had a problem it not entering this piece of code.

Please Note: If you have a language pack installed those translations will win over any theme and module translation phrases.
If you have any inline translations (DB table translation) these will win over all language pack, theme and module phrases.

My fix was specifically targeted at theme i18n folder translations e.g. [Theme]/i18n/en_GB.csv.

Thanks
Tadhg

[12impress]

Hi @tadhgbowe

I did all things you mentioned. When I do Stores > Configuration > General > Locale Options : the Locale for you needs to be set to Dutch (Netherlands). The Java script at the backend crashed. When I put it back in en_US the Java workts but there is missing tekst, My admin login is also set to en_US and still tekst is missing.

I will try do delete the theme files and run setup again. Than set to blank theme. Maybe this solves the issue...