Product::addImageToMediaGallery throws Exception

[R4c00n]

Hi folks,
I'm trying to add some images to a product, but it's not working like expected.

Preconditions

Magento Version 2.1.1
PHP Version 7.0

Steps to reproduce

$product = $this->productFactory->create()
            ->setName($productName)
            ->setStatus($productStatus)
            ->setSku($productSku)
$product->setAttributeSetId($product->getDefaultAttributeSetId());

$product->addImageToMediaGallery($file, [
                'image',
                'small_image',
                'thumbnail',
            ], false, false);
$this->productRepository->save($product);

Expected result

Image gets added

Actual result

Exception gets thrown:

Notice: Undefined index: media_type in /var/www/magento.fissler.local/vendor/magento/module-catalog/Model/Product.php on line 2527

There's a workaround for this issue, using the Product::save method instead of the ProductRepositoryInterface::save method, but because it's a deprecated method I would like to avoid this.

[R4c00n]

I've encountered an additional bug, when using the Product::save-workaround:

function addImages() {
    $product = $this->productFactory->create()
            ->setName($productName)
            ->setStatus($productStatus)
            ->setSku($productSku)
    $product->setAttributeSetId($product->getDefaultAttributeSetId());

    $product->addImageToMediaGallery($file, [
                'image',
                'small_image',
                'thumbnail',
            ], false, false);
    $product->save()

    // Fake the behavior of ProductRepository::save
    return $this->productRepository->get($product->getSku());
}

$product = $this->addImages();
$this->productRepository->save($product);

The ProductRepository::save call removes all media gallery entries.

[sparrowek]

The same problem for me - strange is that is was working previously but it stopped after base url for media files was changed

[maciejtrybula]

The same problem here, any chance to fix it?

[eduard-kistner]

Same here, 3 months gone and no response ?!
@magento-team Please fix that, otherwise this method makes absolutely no sense if we cant use it the preferred ( new ) way.

[KrystynaKabannyk]

hello @sparrowek, @szpadyzor, @eduard-kistner, could you please clarify which versions do you use?

[maciejtrybula]

@KrystynaKabannyk version 2.1.1, PHP 7.0, like in 1st post.

[eduard-kistner]

Hi @KrystynaKabannyk,

shure:

• Magento ver. 2.1.2
• PHP 5.6.27-0+deb8u1 ( on Docker Dev box )

In my humble opinion the only missing part is that in
Magento\Catalog\Model\Product\Gallery\Processor -> addImage(...)
there will be no media_type set in the $mediaGalleryData array elements.

The workaround with deprecated save() ( mainly ) works for me.
So i get the images in backend but not assigned to image / thumbnail etc. ( havent debugged it yet ).

[eduard-kistner]

I did some more research as the change mentioned above does not work completely well.

It will seems to fit as no more exception will be thrown, but no images will be shown on product side then.
So there is some more ( confusing ) stuff going on when the ProductRepository saves an product.

The main Problem seems then to be that the method processMediaGallery() will not recognize entries which correspond to an file.
If the image is new it only will add entries to the product which have the content key set.
Also there seems to be lot of setting / unsetting of product media items, which maybe have there use case but i could not find them.

In the end i have created an module to fix that.
Its possible that i have not taken all cases into account ( hopefully @magento-team will do complete refactoring ) but for me it works.

[mariusjp]

Also ran into this problem today.
I don't want to fallback to $product->save(); so @eduard-kistner thx for your module!
I ran into a similar issue when saving categories:
http://magento.stackexchange.com/questions/161021/category-attribute-not-saving-with-repointerface

If this is not in it's correct place here, I'm sorry

[quickshiftin]

I am unable to get this working either, having tried a variety of approaches. Here's what I have tried:

• Using $productRepo->save($product)
• Using $productRepo->save($product) with @eduard-kistner module
• Using $product->save() followed by $productRepo->save($product)
• Using $product->save() followed by $productRepo->save($product) with @eduard-kistner module

Nothing has worked. I'm on Magento 2.1.5, PHP 7.0.15

The only thing I seem to be doing differently than others is setting the $move parameter to true, but I don't think that should matter, based on the comments of Magento\Catalog\Model\Product\Gallery\Processor::addImage. I tried setting $move to false to no avail as well.

What happens for me is an image is associated with the product, but none of 'roles' are set in the admin when I view the product.

If I set the roles manually in the admin, after a programmatic load, it seems to work. Strangely the admin doesn't seem to be using Magento\Catalog\Model\Product\Gallery\Processor::addImage, because I put a die statement at the top of the function and the save operation in the admin went through without a problem.

That said, I haven't taken the time to break out the debugger to see what kind of workaround might actually work, though I'm sure there is one lurking behind a debug session.

[eduard-kistner]

@quickshiftin
Updated to 2.1.5 and with PHP 7.0.15 / nginx but could not find an problem with setting the media attribute like
$product->addImageToMediaGallery('/path/to/image.jpg', ['image', 'small_image', 'thumbnail', 'swatch_image'], true, false);

But maybe we should not spam this ticket ;)

[quickshiftin]

@eduard-kistner
I just did a fresh install of Magento 2.1.5 PHP 7.0.8 / apache. Without your extension I'm still getting the error message Notice: Undefined index: media_type. Once I install your extension, setting media attributes still does not work.

I went ahead an made a module to demonstrate the problem. Maybe there's a glaring error in there you could point out :)