Inconsistent cms block validation and save methods

[vovayatsyuk]

Additional information

The issue was reopened on 16 July 2019.
The reopening reason is that current behavior(after fixes) brings new issues. See comment for details

1. Currently, I have to re-save an existing block (select every store view except one manually) and only after that, I can finally create a block for a specific store view.
2. Previously, I could add a new block and it just works. Magento correctly used the fallback mechanism to show the correct block at every store view.

Additionally, when using a new approach, if I'll create a new store view I have to open cms block again and select newly created store view in store views combo box. Previously all work flawlessly because I always had a default block saved with "All store views" selected.

Preconditions

Magento develop branch

Steps to reproduce

1. Install Magento from develop branch.
2. Make sure that you have only one store view and SingleStoreMode option in disabled
3. Create cms block example for All Store views
4. Create another cms block example for first store view only

Expected result

1. Block should be saved for selected store view

Actual result

1. An exception will be thrown:

   A block identifier with the same properties already exists in the selected store.
   

Propose

Validator should validate actual block data, so we can remove the following check completely:

if ($this->_storeManager->hasSingleStore()) {
    $stores = [Store::DEFAULT_STORE_ID];
}

https://github.com/magento/magento2/blob/develop/app/code/Magento/Cms/Model/ResourceModel/Block.php#L186-L188

OR

this logic should be moved to _beforeSave and slightly modified, to check SingleStoreMode option:

if ($this->_storeManager->getSingleStoreMode()) {
    $object->setData('stores', [Store::DEFAULT_STORE_ID]);
}

[IlnitskiyArtem]

@vovayatsyuk, Thanks for the feedback.
I reproduced it on last Magento 2 develop branch. Also i tried to create CMS Blocks with same identifiers at first for the Default Store View, and just then for All. In such way it worked.
The logic is that when you create it for All Sore Views at first with Single Store mode disabled, CMS Block identifier Is for all stores and cannot be duplicated. In other way, when you create it for a particular Store View, it checks just certain area where it is already created.
That functional with disable Single Store is not a bug.

[vovayatsyuk]

Thanks, I know why it shows an error and I wrote a proposed solution that will fix this behavior.

If you'll dig into this a little more, you'll see that validation and save methods are inconsistent:

Save method uses data from the request, while validation does not. Validation put a [Store::DEFAULT_STORE_ID] into $stores variable but the actual stores are left in the object and will be saved as well if validation will return true.

And that is a bug, I think. It's not a valid behavior when validation checks data that will not be saved actually.