Skip to content

[Issue] Fix bad \Magento\Sales\Model\Order\Email\Container\Template::$id property #39151

@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #39150: Fix bad \Magento\Sales\Model\Order\Email\Container\Template::$id property


Description (*)

This PR fix the bad phpdoc for \Magento\Sales\Model\Order\Email\Container\Template::$id, actually $id is type int but in reality is string.

Capture d’écran du 2024-09-10 10-56-41

For example, with PHPSTAN is very complicated to setup the project with level 5 or higher :(

Capture d’écran du 2024-09-10 10-58-47

Workaround

Add @phpstan-ignore-next-line before call setTemplateId :(

Capture d’écran du 2024-09-10 11-00-08

Related Pull Requests

None

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

Setup PHPSTAN with level 5 or higher and run check.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions