-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Priority: P1Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing.Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing.Progress: doneProject: Platform Health
Description
We are faced with the problem of false positive fail for the sniff Magento2.Annotation.MethodAnnotationStructure
when added #[\ReturnTypeWillChange]
attribute to make compatibility with PHP 8.1
example:
/**
* Check if given type is any type.
*
* @param string $type
* @return bool
*/
#[\ReturnTypeWillChange]
public function isTypeAny($type)
Expected result (*)
Results of the static tests should be passed for this issue
Actual result (*)
FILE: /var/www/html/lib/internal/Magento/Framework/App/Cache/Frontend/Pool.php
------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
------------------------------------------------------------------------------
101 | WARNING | Comment block is missing
111 | WARNING | Comment block is missing
121 | WARNING | Comment block is missing
131 | WARNING | Comment block is missing
141 | WARNING | Comment block is missing
------------------------------------------------------------------------------
ihor-sviziev
Metadata
Metadata
Assignees
Labels
Priority: P1Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing.Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing.Progress: doneProject: Platform Health