The Multishipping::beforeSetShippingMethods() method can be simplified by removing unused $methods argument

[dmitrii-fediuk]

https://mage2.pro/t/490

magento/devdocs#516, #3326
See also: #3340

[ishakhsuvarov]

@dfediuk Thank you for reporting this issue. We have created an internal ticket MAGETWO-49548 to improve the method in question.

[okobchenko]

@dfediuk We have investigated reported problem. Unused formal parameter was added for consistency between plugin and pluginized method. There is a convention requiring that "before" plugin receives subject (instance of pluginized object) and list of input parameter of pluginized method. Theoretically particular code can work with $methods argument removed, but this will decrease visibility of relation between methods and arguments exchange and is not recommended practice.

[ishakhsuvarov]

@dfediuk Closing this issue for now. Please feel free to reopen if you have any additional questions.