Eav Group Repository Order not changing.

[LucianMihalache]

Preconditions (*)

1. I tried on magento 2.3.1.
2. Fresh and developer instances.

Steps to reproduce (*)

1. The problem is that you cannot update the order of a group in an attribute set by repository. It does not have support for it.

Basically, I am trying to update the groups of some attribute set via rest api.
The code asks for a specific format

{
  "group": {
    "attribute_group_id": "string",
    "attribute_group_name": "string",
    "attribute_set_id": 0,
    "extension_attributes": {
      "attribute_group_code": "string",
      "sort_order": "string"
    }
  }
}

But it does not work. When I debugged what was being received by the site, it returned:

(vendor/magento/module-eav/Model/Attribute/GroupRepository.php::save())

2019-07-09T09:06:01+00:00 INFO (6): Array

(
    [attribute_group_name] => Product Details
    [attribute_group_id] => 336
    [attribute_set_id] => 39
)

While my posted data was:

2019-07-09T08:46:02+00:00 INFO (6): Array

(
    [group] => Array
        (
            [attribute_group_name] => Product Details
            [extension_attributes] => Array
                (
                    [sort_order] => 1
                    [attribute_group_code] => product-details
                )

            [attribute_group_id] => 336
            [attribute_set_id] => 39
       )

)

After the repository saves the group (calls resource->save()), it returns:

2019-07-09T09:06:01+00:00 INFO (6): Array
(
    [attribute_group_name] => Product Details
    [attribute_group_id] => 336
    [attribute_set_id] => 39
    [attribute_group_code] => product-details
    [sort_order] => 83
)

Which is normal, because in the group model, in beforeSave, there is

(vendor/magento/module-eav/Model/ResourceModel/Entity/Attribute/Group.php::_beforeSave())

if (!$object->getSortOrder()) {
        $object->setSortOrder($this->_getMaxSortOrder($object) + 1);
 }

Expected result (*)

1. To be able to set the order of some attribute groups

Actual result (*)

1. Saving an attribute group by its repository auto-increments its old order.

[m2-assistant]

Hi @LucianMihalache. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@LucianMihalache do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @engcom-Charlie. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[LucianMihalache]

I updated the question with more details and valid data.

[engcom-Charlie]

Hello @LucianMihalache ! Thank you for report
Can you show which Rest Api calls did you use when reproduce this issue ?

[LucianMihalache]

@engcom-Charlie
Isn't there only one rest api call for this?
/rest/all/V1/products/attribute-sets/groups.

[magento-engcom-team]

✅ Confirmed by @engcom-Charlie
Thank you for verifying the issue. Based on the provided information internal tickets MC-17997 were created

Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[LucianMihalache]

@engcom-Charlie thank you for looking into this.
Can you please look into #23172 too?
It is about attribute groups too.
The problem is that you can't filter the group repository (with attribute set id filter and attribute group filter) with any other condition_type than =
More details there.