Skip to content

\Magento\ImportExport\Block\Adminhtml\Export\Filter::_getSelectHtmlWithValue() method overwrites self $value argument #20624

@andkirby

Description

@andkirby

There is the issue described in the summary.

Preconditions (*)

  • Magento EE v2.2.5
  • Targed class/method is \Magento\ImportExport\Block\Adminhtml\Export\Filter::_getSelectHtmlWithValue()

Steps to reproduce (*)

It's clear in the code the $value variable

protected function _getSelectHtmlWithValue(Attribute $attribute, $value)

is gonna be overwritten in

            foreach ($attribute->getFilterOptions() as $value => $label) {
                $options[] = ['value' => $value, 'label' => $label];
            }

Expected result (*)

Different names for different $value variables must be set.

Actual result (*)

There is same name for different $value variables.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Component: ImportExportFixed in 2.2.xThe issue has been fixed in 2.2 release lineFixed in 2.3.xThe issue has been fixed in 2.3 release lineIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentProgress: PR CreatedIndicates that Pull Request has been created to fix issueReproduced on 2.2.xThe issue has been reproduced on latest 2.2 releaseReproduced on 2.3.xThe issue has been reproduced on latest 2.3 release

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions