-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Component: CheckoutFixed in 2.2.xThe issue has been fixed in 2.2 release lineThe issue has been fixed in 2.2 release lineFixed in 2.3.xThe issue has been fixed in 2.3 release lineThe issue has been fixed in 2.3 release lineIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentGate 4. Acknowledged. Issue is added to backlog and ready for developmentReproduced on 2.2.xThe issue has been reproduced on latest 2.2 releaseThe issue has been reproduced on latest 2.2 releaseReproduced on 2.3.xThe issue has been reproduced on latest 2.3 releaseThe issue has been reproduced on latest 2.3 release
Description
Preconditions
- Magento 2.2.6
Steps to reproduce
- Create any simple product
- Add to cart it on frontend and go to checkout
- Open Chrome Dev Tools
- Fill up shipping in US with any address
- Find request to request like this: https://test-magento-instance.com/rest/default/V1/guest-carts/gFgmi7qopaxOgxlbXQ3hEo2Ny8gkNXXl/estimate-shipping-methods
- Right click on this request on click "Block request URL" in order to emulate that we can't connect to server or server returned an error

- Change zipcode in shipping address and see that estimate-shipping-methods request was blocked in Dev Tools:

Expected result
- Loading indicator should be hidden
- No shipping methods should be available
Actual result
- Infinite scrolling in "Shipping methods" appeared
Additional info
Issue appearing here:
https://test-magento-instance.com/pub/static/version1538398224/frontend/Magento/luma/en_US/Magento_Checkout/js/model/shipping-rate-processor/new-address.js contains following line - errorProcessor tries to process response

but it can't process JSON.parse on empty string and throwing exception:

As result we "always" section in new-address.js file is not processed.
We have following JS error in console:

PS: I tested it on following test instance: https://i-18112-2-2-6.engcom.dev.magento.com/test.html
Metadata
Metadata
Assignees
Labels
Component: CheckoutFixed in 2.2.xThe issue has been fixed in 2.2 release lineThe issue has been fixed in 2.2 release lineFixed in 2.3.xThe issue has been fixed in 2.3 release lineThe issue has been fixed in 2.3 release lineIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentGate 4. Acknowledged. Issue is added to backlog and ready for developmentReproduced on 2.2.xThe issue has been reproduced on latest 2.2 releaseThe issue has been reproduced on latest 2.2 releaseReproduced on 2.3.xThe issue has been reproduced on latest 2.3 releaseThe issue has been reproduced on latest 2.3 release