Skip to content

Some of JS validation rules making fields required #16544

@VitaliyBoyko

Description

@VitaliyBoyko

Hi, dear Magento Comunity Engineering team.
In some cases quite useful to have validation only for the filled fields. For example:
we have on the form field phone which is not required, but it required to have valid data when user will fill out this field. In case if a user did not fill out anything error should not be displayed.
Bunch of validation rules makes this not possible.

On the screenshot, I've selected more important validation rules for my opinion. Some of them work fine, others have unexpected behavior.

new form content magento admin

Here form source to more convenient reproducing.

Preconditions

  1. Create a new module with form and field, or add a field to existing form
  2. Set field validation, for example:
    <validation> <rule name="phoneUS" xsi:type="boolean">true</rule> </validation>
  3. Field should not be required

Steps to reproduce

  1. Don't fill out the field just submit a form

Expected result

  1. The form is submitting as well

Actual result

  1. Form not being submitted, field validation process error

Metadata

Metadata

Assignees

Labels

Component: UiFixed in 2.2.xThe issue has been fixed in 2.2 release lineFixed in 2.3.xThe issue has been fixed in 2.3 release lineIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentReproduced on 2.2.xThe issue has been reproduced on latest 2.2 releaseReproduced on 2.3.xThe issue has been reproduced on latest 2.3 release

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions