Checkout/Model/Session doesn't set the $quoteIdMask

[daanggc]

In the file magento2/app/code/Magento/Checkout/Model/Session.php on line 256 there seem to be a small error.

$this->isQuoteMasked() us used to get the bool $isQuoteMasked but that should be $this->getIsQuoteMasked() or $this->isQuoteMasked

[vpelipenko]

Hi @daancart2quote, there is a long discussion about naming convention here #935. We don't have strict rules how method should be named, only recommendations. In this case, I think, it is OK to use name 'isQuoteMasked', look at the latest @TexanHogman comment.

[daanggc]

Hello @vpelipenko,

The issue is not the naming, the issue is that function isQuoteMasked() doesn't exits.
So, $this->isQuoteMasked() won't work. (AFAIK this should be labeled as a bug)

So to follow the example of @TexanHogman, the way to solve this is to add the following function:

    /**
     * @return bool|null
     */
    protected function isQuoteMasked()
    {
        return $this->isQuoteMasked;
    }

[vpelipenko]

Probably, I missed something... but isQuoteMasked method exists in this class https://github.com/magento/magento2/blob/develop/app/code/Magento/Checkout/Model/Session.php#L504

[daanggc]

It looks like my beta was just a version older... Sorry!
Anyway thanks for your time!