Issue when we create a new product with double quotes in the title

[p3ll3]

Preconditions

1. Magento version 2.2.4
2. PHP 7.0.30-0ubuntu0.16.04.1

Steps to reproduce

1. Go to Catalog >> Products
2. Create a new product with double quotes, e.g. PROBASS BAFLE 15" 1000W
3. Go to the detailed view of the product

Expected result

1. Product loading correctly:
   

Actual result

1. Error in console :
   
2. Tabs of the product section, breadcrumbs, product images and information tabs not loading correctly.
   

Kind regards!

Hello,
We have a solution for this issue, you have faced this issue just because of breadcrumb feature update.
To solve this issue override "breadcrumb.phtml" file in your theme

app/design/frontend/[THEME VENDOR]/[YOUR THEME]/Magento_Catalog/templates/product

path and replace with below code.

<?php
/**
 * Copyright © Magento, Inc. All rights reserved.
 * See COPYING.txt for license details.
 */
/** @var \Magento\Theme\Block\Html\Breadcrumbs $block */
/** @var \Magento\Catalog\ViewModel\Product\Breadcrumbs $viewModel */
$viewModel = $block->getData('viewModel');
?>
<div class="breadcrumbs" data-mage-init='{
    "breadcrumbs": {
        "categoryUrlSuffix": "<?= $block->escapeHtml($viewModel->getCategoryUrlSuffix()); ?>",
        "useCategoryPathInUrl": <?= (int)$viewModel->isCategoryUsedInProductUrl(); ?>,
        "product": "<?= $block->escapeHtml($block->escapeJsQuote($viewModel->getProductName(), '"')); ?>"
    }
}'>
</div>

Actually this issue is already fixed #15347 and The fix will be available with the upcoming 2.2.5 release. Click here and see.

I hope it will help you !!.

[p3ll3]

Thank you @emiprotech , I'll try that solution and hopefully with the upcoming of Magento 2.2.5 the issue will be solved.

[DanielRuf]

Thank you @emiprotech , I'll try that solution and hopefully with the upcoming of Magento 2.2.5 the issue will be solved.

It's not in 2.2.5.

[DanielRuf]

See 213e11d#diff-3f348dd219394a12da6df66aa9410956

[DanielRuf]

And also

magento2/app/code/Magento/Catalog/ViewModel/Product/Breadcrumbs.php

Line 111 in 40e2672

'product' => $this->getProductName()

[hostep]

In case anyone's interested, here's the patch we use to get it working on Magento 2.2.5.

Apply it to the Magento_Catalog module: ENGCOM-1703-Catalog.diff.txt

Fix is already in 2.2-develop branch as @DanielRuf noticed, by this PR: #15521

The patch isn't an exact implementation of the PR, since other very small commits prevented applying that PR cleanly on Magento 2.2.5, but the patch I've attached above does apply cleanly to Magento 2.2.5

[DanielRuf]

In case anyone's interested, here's the patch we use to get it working on Magento 2.2.5.

Apply it to the Magento_Catalog module: ENGCOM-1703-Catalog.diff.txt

Fix is already in 2.2-develop branch as @DanielRuf noticed, by this PR: #15521

The patch isn't an exact implementation of the PR, since other very small commits prevented applying that PR cleanly on Magento 2.2.5, but the patch I've attached above does apply cleanly to Magento 2.2.5

We use 2.2.5 and it is not fixed. The article name is not escaped. We had to overwrite the ViewModel.

[DanielRuf]

getProductName and "product": "<?= $block->escapeHtml($block->escapeJs($viewModel->getProductName())); ?>" are not the fixed version.

[hostep]

I know, have you checked the patch or the PR? ;)

[DanielRuf]

@magento-engcom-team give me 2.2.5 instance

[magento-engcom-team]

Hi @DanielRuf. Thank you for your request. I'm working on Magento 2.2.5 instance for you